Skip to content

stop propagating input of type file #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2021
Merged

stop propagating input of type file #1101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0767cd
stop propagating input of type file
yann300 Apr 8, 2021
b5c2366
Update file-explorer.tsx
yann300 Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion libs/remix-ui/file-explorer/src/lib/file-explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,12 @@ export const FileExplorer = (props: FileExplorerProps) => {
// the files module. Please ask the user here if they want to overwrite
// a file and then just use `files.add`. The file explorer will
// pick that up via the 'fileAdded' event from the files module.
const parentFolder = state.focusElement[0] ? state.focusElement[0].type === 'folder' ? state.focusElement[0].key : extractParentFromKey(state.focusElement[0].key) : name
const expandPath = [...new Set([...state.expandPath, parentFolder])]

setState(prevState => {
return { ...prevState, expandPath }
});

[...target.files].forEach((file) => {
const loadFile = (name: string): void => {
Expand Down Expand Up @@ -545,7 +551,7 @@ export const FileExplorer = (props: FileExplorerProps) => {
}
fileReader.readAsText(file)
}
const name = file.name
const name = `${parentFolder}/${file.name}`

filesProvider.exists(name, (error, exist) => {
if (error) console.log(error)
Expand Down Expand Up @@ -994,6 +1000,8 @@ export const FileExplorer = (props: FileExplorerProps) => {
label={
<div onClick={(e) => {
e.stopPropagation()
if (e && (e.target as any).getAttribute('data-id') === 'fileExplorerUploadFileuploadFile') return // we don't want to let propagate the input of type file

let expandPath = []

if (!state.expandPath.includes(props.name)) {
Expand Down