Skip to content

fix FE not rendering and display alert #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2021
Merged

fix FE not rendering and display alert #1073

merged 2 commits into from
Apr 7, 2021

Conversation

bunsenstraat
Copy link
Collaborator

No description provided.

@bunsenstraat bunsenstraat requested a review from yann300 April 2, 2021 14:16
@bunsenstraat bunsenstraat changed the title fix FE not rendering and displayt alert fix FE not rendering and display alert Apr 2, 2021
@bunsenstraat bunsenstraat mentioned this pull request Apr 6, 2021
Closed
LianaHus
LianaHus reviewed Apr 6, 2021
View reviewed changes
@bunsenstraat bunsenstraat requested a review from LianaHus April 6, 2021 10:11
@github-actions github-actions bot force-pushed the fixnotrenderingFE branch from a2cb4d6 to 02fe291 Compare April 6, 2021 11:03
@yann300 yann300 removed the autorebase label Apr 6, 2021
@EthereumRemix EthereumRemix merged commit a280a5b into master Apr 7, 2021
@EthereumRemix EthereumRemix deleted the fixnotrenderingFE branch April 7, 2021 09:27
@yann300
Copy link
Contributor

yann300 commented Apr 13, 2021

step for testing the feature:

  • copy 0.10.10 assets to the asset folder of the platform being tested.
  • browse 0.10.10, remove the .workspace folder, keep some folders and files at the root.
  • browse 0.11.3, the modal should appear.
  • migrate and reload 0.11.3, files should have been migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yann300 yann300 yann300 approved these changes

@ioedeveloper ioedeveloper Awaiting requested review from ioedeveloper

@LianaHus LianaHus Awaiting requested review from LianaHus

Assignees

No one assigned

Labels

autosquash

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bunsenstraat @yann300 @LianaHus @EthereumRemix