Skip to content

Bunsenstraat patch 1 #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 29, 2020
Merged

Bunsenstraat patch 1 #299

merged 5 commits into from
Dec 29, 2020

Conversation

@bunsenstraat
Copy link
Collaborator

@bunsenstraat bunsenstraat commented Dec 16, 2020

The object returned by getCompilationResult is not of type CompilationResult but of type lastCompilationResult which contains CompilationResult as data

export interface lastCompilationResult {
    data: CompilationResult | null;
    source: SourceWithTarget | null | undefined;
}

@bunsenstraat
Update output.ts
3143fd1 
lastCompilationResult is what is being returned by getcompilationresult, not a compilationresult
@bunsenstraat
Update api.ts
a9a404e 
return lastcompilationresult, not a compilationresult
@bunsenstraat bunsenstraat requested a review from yann300 December 16, 2020 09:17
@bunsenstraat bunsenstraat merged commit 6dbf881 into remix-project-org:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yann300 yann300 yann300 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bunsenstraat @yann300