Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Var harm #1793

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Var harm #1793

wants to merge 8 commits into from

Conversation

johannah-pik
Copy link
Contributor

Purpose of this PR

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • [x ] New feature
  • [x ] Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • [x ] My code follows the coding etiquette
  • [x ] I performed a self-review of my own code
  • [x ] I explained my changes within the PR, particularly in hard-to-understand areas
  • [ x] I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • [x ] All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?): Only slight changes in the variables reported by EDGE-Transport in order to be consistent with REMIND transport results, pass summation tests and get rid of duplicated variables with different values due to the reporting of both models. This PR is connected to PR #21 in reporttransport

@LaviniaBaumstark
Copy link
Member

can this PR be merged?

@johannah-pik
Copy link
Contributor Author

Hi Lavinia - no this PR was meant for a long-term solution I was working on regarding the variable harmonization.
Sadly, this long-term solution is not there yet, because other problems popped up. I hope it can be merged next week..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants