Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing columns cm_implicitQttyTarget, cm_emiMktTarget, cm_altFeEmiFac to DeepEl scenario config #1462

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member Author

bump @cchrisgong

@cchrisgong
Copy link
Contributor

thanks, Michaja! sorry for the delay. These switches look like they are EU specific targets? Should they be in all Deep_El which is a global scenario? Are they legally bound targets? maybe they should be in a separate deepEl_eur config?
dankee

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member Author

These are switches introduced into the default scenarios in scenario_config.csv after DeepEl was run. Unless there is a rationale for excluding/altering them from the values in the default scenarios, they should be included with DeepEl as well, no?

@cchrisgong
Copy link
Contributor

@LaviniaBaumstark

@cchrisgong
Copy link
Contributor

Lavinia said config.csv should be always aligned with main.gms. These switches she is not aware of. I believe their values in scenario_config.csv and in main.gms are not the same (so two different "default"). Would like to know if we need to change it where, or how to move forward with this PR

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member Author

Unless there is a rationale for excluding/altering them from the values in the default scenarios, they should be included with DeepEl as well, no?

@cchrisgong
Copy link
Contributor

In main.gms $setGlobal cm_implicitQttyTarget off !! def = off
is the default value, in the scenario_config.csv, there are some other values I understand? Because mostly Felix would like to test them in the AMT regularly to monitor their behaviors. This is not the objective of deepEl, since AMT is not run from it, and therefore should not need these switches on.. imo

@LaviniaBaumstark
Copy link
Member

can this PR be closed?

@cchrisgong
Copy link
Contributor

still thinks cm_implicitQttyTarget in the config csv should be default and not contain EU switches.. @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants