Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info about model version to full.gms #1398

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

LaviniaBaumstark
Copy link
Member

Purpose of this PR

add info about model version to full.gms

Type of change

  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. Should you add that to main.gms as well?

@LaviniaBaumstark
Copy link
Member Author

it is added to the main.gms file in the output folder but not to the main.gms file on the top level

@orichters
Copy link
Contributor

orichters commented Sep 6, 2023

it is added to the main.gms file in the output folder but not to the main.gms file on the top level

maybe we should delete this information completely in main.gms and just keep a placeholder. * Last modification (input data): Wed Sep 28 10:35:42 2022 as it is stated now is a bit misleading :)

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@LaviniaBaumstark LaviniaBaumstark merged commit e82cb11 into remindmodel:develop Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants