Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove snapshot support #1357

Merged
merged 2 commits into from
Jul 13, 2023
Merged

remove snapshot support #1357

merged 2 commits into from
Jul 13, 2023

Conversation

pfuehrlich-pik
Copy link
Contributor

@pfuehrlich-pik pfuehrlich-pik commented Jul 13, 2023

Purpose of this PR

Renv now fully supersedes snapshots, so this PR removes all snapshot related code.

Type of change

  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

@dklein-pik
Copy link
Contributor

I'd prefer to keep the snapshot functionality until the next MAgPIE release that also supports renv.

@pfuehrlich-pik pfuehrlich-pik merged commit 718973c into remindmodel:develop Jul 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants