MAgPIE coupling: code cleaning

[dklein-pik]

Purpose of this PR

Delete old code

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

• Bug fix
• Refactoring
• New feature
• Minor change (default scenarios show only small differences)
• Fundamental change
• This change requires a documentation update

Checklist:

• My code follows the coding etiquette
• I performed a self-review of my own code
• I explained my changes within the PR, particularly in hard-to-understand areas
• I checked that the in-code documentation is up-to-date
• I adjusted the reporting in remind2 where it was needed
• I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
• All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

• Test runs are here:
• Comparison of results (what changes by this PR?):

[orichters]

Assuming make test-coupled works, I'm absolutely fine with deleting this old stuff.

I looked at the code changes and they look convincing.

Thanks!

[orichters]

So the mode was simply activated by setting debug = TRUE here?

[dklein-pik]

Yes. But the new opportunity witht the empty models is much more useful.

[dklein-pik]

Assuming make test-coupled works, I'm absolutely fine with deleting this old stuff.

I looked at the code changes and they look convincing.

Thanks!

Yes, make test-coupled works.