Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lst file2 #1254

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

robertpietzcker
Copy link
Contributor

@robertpietzcker robertpietzcker commented Mar 14, 2023

Purpose of this PR

Improve convergence of p47_implicitQttyTargetTax:

  • relax the bounds on rescale a bit
  • instead use a formulation that reduces rescalings that are closer to 1 than 1.5/ 0.75

Type of change

  • Minor change (default scenarios show only small differences)

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

@LaviniaBaumstark
Copy link
Member

what is the status of thsi PR? will you continue working on it?

@LaviniaBaumstark
Copy link
Member

How to procced with this PR @robertpietzcker @robinhasse ?

@robinhasse
Copy link
Contributor

robinhasse commented Sep 9, 2024

I don't feel qualified to judge the changes in module 47. But some changes in the building module seem wrong to me. Are the additional lines around f_cf intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants