Fix infinite loop when parsing nested associations #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somebody please give a medal to this man! (and merge this PR 😛 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears with this commit a potential infinite loop was introduced if models defined both has_many/belongs_to.
To mitigate this, I've added a straightforward check for
belongs_toto no-op if the association is already defined on the resulting object. Also, sorry for the previous PR! Moved this under my company's organization for easy access to the rest of my team.Finally, it appears we're now respecting
included_root_elementfor nested associations. This PR also adds an option to opt out of this new behavior as well as potentially use a different name viaincluded_embedded_root_element