Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: add tsdocs for parser options, note pedantic is deprecated #480

Merged
merged 1 commit into from
Mar 28, 2020
Merged

typings: add tsdocs for parser options, note pedantic is deprecated #480

merged 1 commit into from
Mar 28, 2020

Conversation

ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Mar 28, 2020 •
edited
Loading

follow up to #477 (review)
adding tsdocs for remark options and noting pedantic mode is deprecated.

Screenshot from 2020-03-27 17-01-08

@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 📚 area/docs This affects documentation 🔍 status/open and removed 🔍 status/open labels Mar 28, 2020
wooorm added a commit that referenced this pull request Mar 28, 2020
@wooorm
Add deprecation note for pedantic mode
4a6dcc9 
Closes GH-470.
Closes GH-477.
Related-to GH-480.

Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>
@wooorm wooorm merged commit 5f9114f into remarkjs:master Mar 28, 2020
@ChristianMurphy ChristianMurphy deleted the types/add-tsdocs-for-parser-options branch March 28, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees
No one assigned
Labels
📚 area/docs This affects documentation ☂️ area/types This affects typings
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianMurphy @wooorm