Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix this type in TS 4.9 #304

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

fix this typing in TS4.9

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 11, 2023
@ChristianMurphy ChristianMurphy mentioned this pull request Jan 11, 2023
5 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ccbf2d3) compared to base (cabbe86).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #304   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines         8486      8487    +1     
=========================================
+ Hits          8486      8487    +1     
Impacted Files Coverage Δ
packages/remark-lint/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wooorm wooorm changed the title types: fix this typing in TS4.9 Fix this type in TS 4.9 Jan 12, 2023
@wooorm wooorm merged commit f41df8e into remarkjs:main Jan 12, 2023
@wooorm wooorm added ☂️ area/types This affects typings 💪 phase/solved Post is done labels Jan 12, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 12, 2023
@ChristianMurphy ChristianMurphy deleted the types/fix-this branch January 12, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

3 participants