no-empty-url: check urls from definitions #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
First, thank you for remark and the unified ecosystem!
This is a small fix to allow remark-lint-no-empty-url to also consider the URLs of
Definition
nodes when linting. When I first used this rule, I assumed that, because of the name, it would apply to all URLs. However, after using remark-reference-links, any mistakenly empty URLs normally caught by this rule were transformed into mistakenly empty definitions that were no longer caught by this rule, which came as a surprise to me.Along with updated tests and documentation, I'm currently using my forked version across several projects if you want to test it out real quick: