Type-safe severity/options normalization #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
wooorm
approved these changes
Apr 1, 2022
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
🤞 phase/open
ChristianMurphy
approved these changes
Apr 1, 2022
|
Can you fill out the checklist in the template? :) |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
What do you think of this cosmetic change to the
coerce()function?It's not an important change. As I see it the advantage is it eliminates the
// @ts-expect-error: it’s now a valid tuple.exception, so the type checker confirms it actually returns aSeverityTuple.I'm happy to make any stylistic changes you suggest!