Optimize the Components type #893
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way we used `ElementType` caused a significant increase of resource usage for TypeScript. I can’t really explain it, but this fixes it. I’m personally inclined to say people should avoid using the `JSX` namespace, but I see no other way around it. Without this change, autocompletion in my editor takes a noticable time to load. Now it’s instant. On my machine this halves the time of running `tsc -b` from ~15s to ~7s. Closes #883
remcohaszing
added
🐛 type/bug
Member
ChristianMurphy
left a comment
ChristianMurphy
left a comment
There was a problem hiding this comment.
I'm neutral on this.
I'm cautious about applying a fix we don't understand to a problem we don't understand.
That said nothing about this code seems particularly worrying.
4 tasks
wooorm
approved these changes
Mar 3, 2025
Member
|
I noticed this project was very slow recently |
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks, released in |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
The way we used
ElementTypecaused a significant increase of resource usage for TypeScript.I can’t really explain it, but this fixes it. I’m personally inclined to say people should avoid using the
JSXnamespace, but I see no other way around it.Without this change, autocompletion in my editor takes a noticable time to load. Now it’s instant.
On my machine this halves the time of running
tsc -bfrom ~15s to ~7s.Closes #883