Upgrade remark-parse

[rgbkrk]

Unsure if this will break things on the react-markdown side. I wanted to see about upgrading remark (xref: nteract/nteract#3483).

[rgbkrk]

Wow, not a fan of the markup that remark-parse was generating for that unordered list:

    Received value does not match stored snapshot "should handle loose, unordered lists 1".
    - Snapshot
    + Received
      <ul>
        <li>
    -     <p>
    -       foo
    -     </p>
    +     foo
        </li>
        <li>
    -     <p>
    -       bar
    -     </p>
    +     bar
        </li>
      </ul>

EDIT: I read that backwards -- the markup is now cleaner.

[rgbkrk]

@rexxars would you have a chance to check this out? I upgraded remark-parse and updated the snapshot ✨ .

[rgbkrk]

Hurrah! It passes!

[rexxars]

This is a breaking change, since we are no longer getting a loose property from remark.

Remark has changed their list handling and thus we need to reflect this in our renderers by doing similar to mdast-util-to-hast

This PR currently just handles all lists as if they were "tight", which isn't necessarily what people want.

[rgbkrk]

Darn. Beyond the other changes necessary, does this mean you'd want to make a major version bump or forgo upgrading remark?

[rexxars]

I don't really mind a breaking change if it makes sense, but as far as I can tell the functionality is still possible to reproduce with the latest remark, it just needs to be handled differently. I definitely don't want to remove a feature if it's supported by the underlying stack.

[rgbkrk]

I'm not sure what the next steps I should take are, so pending further direction I think I'll have to leave this to other contributors.

[rexxars]

Thanks for the PR, I'm scheduling the upgrade to remark-parse@6 for v5, which is in a separate branch right now: https://github.com/rexxars/react-markdown/tree/v5

[rgbkrk]

Cool, looking forward to it.