Skip to content

refactor: improve parser types #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 3, 2020
Merged

refactor: improve parser types #160

merged 12 commits into from
Jun 3, 2020

Conversation

remarkablemark
Copy link
Owner

  • Improve parser types (options.library)
  • Fix dtslint
  • Use early return for empty string (performance optimization)
  • Tidy tests

@remarkablemark
build(package): save @typescript-eslint/parser to devDependencies
b042b5a
@remarkablemark
chore(eslint): set parser to @typescript-eslint/parser
7a82b3d
@remarkablemark
perf(index): return empty array if first argument is empty string
7f61f97
@remarkablemark
test(html-to-react): add case that empty string returns empty array
d5daa95
@remarkablemark
test: tidy descriptions for describe and it blocks
0273e2d
@remarkablemark
test(types): fix dtslint tests for index.test.tsx
516aa89 
Use single line comment instead of mutli-line comment since the
tests get skipped when using the latter.

Replace `ReactElement` with `Element`.

Fix invalid test for `options.replace`.
@remarkablemark
test(types): add error and more expect cases to index.test.tsx
0d3bc6c
@remarkablemark
chore(index): improve types for options.library
ffb7964
@remarkablemark
test(types): add tests for updated options.library types
3938f56
@remarkablemark
test(types): fix and improve dts tests for dom-to-react.test.tsx
1a32b65
@remarkablemark
docs(index): tidy JSDoc comments for index.d.ts
772ae36
@remarkablemark
docs(lib): improve JSDoc comments for dom-to-react.d.ts
2287038
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2287038 on refactor/parser-types into 8560493 on master.

@remarkablemark remarkablemark merged commit 8ac54fd into master Jun 3, 2020
@remarkablemark remarkablemark deleted the refactor/parser-types branch June 3, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remarkablemark @coveralls