TS Error: Property 'attribs' does not exist on type 'DOMNode'.

[bicstone]

Expected Behavior

When upgrade from version 0.14.3 to 1.0, TypeScript type errors occurs.

error TS2339: Property 'attribs' does not exist on type 'DOMNode'.
error TS2339: Property 'name' does not exist on type 'DOMNode'.
error TS2339: Property 'children' does not exist on type 'DOMNode'.
...etc

Actual Behavior

No error occurs.

Steps to Reproduce

Upgrade from version 0.14.3 to 1.0.

Reproducible Demo

0.14.3: https://codesandbox.io/s/mutable-surf-7r84v?file=/src/App.tsx
1.0: https://codesandbox.io/s/async-wildflower-p1wxl?file=/src/App.tsx

MEMO: 5568ed7#diff-7aa4473ede4abd9ec099e87fec67fd57afafaf39e05d493ab4533acc38547eb8

[remarkablemark]

Thanks for opening this issue!

You'll need to do an instanceof check of domhandler's Element:

import { Element } from 'domhandler/lib/node';

const options: HTMLReactParserOptions = {
  replace: (domNode) => {
    if (
      domNode instanceof Element &&
      domNode.attribs &&
      domNode.name === 'main'
    ) {
      const props = attributesToProps(domNode.attribs);
      return <div {...props} />;
    }
  },
};

See https://codesandbox.io/s/html-react-parser-199-ehdss

Let me know if you think exporting Element from html-react-parser and/or updating the README.md would help.

[bicstone]

Now I understand.
Thank you for your explanation!

[kevinpfox]

If you ended up here and tried the recommended solution and it still didn't work and you aren't interested in processing "Text" nodes and only care about processing "Tag" nodes, you can try the following...

import { isTag } from 'domhandler/lib/node';

replace: (domNode) => {
  if (isTag(domNode)) {
    const { attribs, children, name } = domNode;
  }

I don't know why the recommended solution did not work in our project. It looks logical. For our project domNode instanceof Element was always evaluating as false and execution refused to drop into the protected block.

[kevinpfox]

@remarkablemark, thank you for making your great tool available! Would be great if isTag and Element from domhandler library were exposed via html-react-parser, so domhandler doesn't need to be added as a project dependency. I wonder if html-react-parser's domhandler version and our project's imported domhandler version will go far enough out of sync to introduce a breaking change, or require the same library to be in the bundle twice, far off in the distant future.

[remarkablemark]

@kevinpfox I'm open to exporting isTag (and maybe Element) from domhandler if a lot of people are experiencing pain with the current approach.

I'm open to a PR but I do want to make sure including this won't add to the bundle size too much.

We can continue discussion in #252 if it's similar.

[kevinpfox]

Thanks for mentioning other thread. I tried the following approach and it fixed the same problem without needing to import an additional project dependency. https://gist.github.com/natterstefan/3bc712eca6ff88781d687b7240a78cc1 I'm also working on a Next.js project.

[remarkablemark]

Nice! If this is helpful, would you be interested in opening a PR to document that approach in the README.md?

[peckyboy]

Thanks for opening this issue!

You'll need to do an instanceof check of domhandler's Element:

import { Element } from 'domhandler/lib/node';

const options: HTMLReactParserOptions = {
  replace: (domNode) => {
    if (
      domNode instanceof Element &&
      domNode.attribs &&
      domNode.name === 'main'
    ) {
      const props = attributesToProps(domNode.attribs);
      return <div {...props} />;
    }
  },
};

See https://codesandbox.io/s/html-react-parser-199-ehdss

Let me know if you think exporting Element from html-react-parser and/or updating the README.md would help.

Why is this so though? I think exporting Element from html-react-parser and/or updating the README.md would help greatly.
Thank you.