Skip to content

build: migrate from rollup to tsdown#1469

Merged
remarkablemark merged 2 commits into
masterfrom
build/tsdown
May 25, 2026
Merged

build: migrate from rollup to tsdown#1469
remarkablemark merged 2 commits into
masterfrom
build/tsdown

Conversation

@remarkablemark
Copy link
Copy Markdown
Owner

@remarkablemark remarkablemark commented May 25, 2026

What is the motivation for this pull request?

Refactor the package build from Rollup to tsdown while preserving the existing published module layout, and remove the now-unused dist/htmlparser2.js browser bundle.

What is the current behavior?

The package build is orchestrated through Rollup plus shell/codemod helpers, including a source-mutating ESM build flow. The build also emits dist/htmlparser2.js, which is no longer used by the current test suite.

What is the new behavior?

The package now builds through tsdown with explicit CJS, ESM, and UMD targets. The Rollup config and helper scripts are removed, the ESM smoke test is kept under __tests__/esm, ESLint/TS config is adjusted for the new bundler config file, and dist/htmlparser2.js is no longer produced.

plan.md

Checklist:

@remarkablemark remarkablemark self-assigned this May 25, 2026
@remarkablemark remarkablemark added the dependencies Pull requests that update a dependency file label May 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-dom-parser.min.js 2.18 KB (-5.03% 🔽) 44 ms (-5.03% 🔽) 93 ms (+56.24% 🔺) 136 ms

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3a3929c) to head (ed823cb).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1469   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          122       122           
  Branches        31        31           
=========================================
  Hits           122       122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remarkablemark remarkablemark merged commit f2e3b85 into master May 25, 2026
22 checks passed
@remarkablemark remarkablemark deleted the build/tsdown branch May 25, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant