feat: add button in debug toolbar to stop profiling

Related: microsoft#388
relief-melone · Mar 27, 2020 · 7af4833 · 7af4833
1 parent 254c5b1
commit 7af4833
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 5 deletions.
diff --git a/demos/node/vscode-js-profile-d82d7c73.cpuprofile b/demos/node/vscode-js-profile-d82d7c73.cpuprofile
diff --git a/package.json b/package.json
@@ -237,12 +237,14 @@
       {
         "command": "extension.NAMESPACE(node-debug).startProfile",
         "title": "%profile.start%",
-        "category": "Debug"
+        "category": "Debug",
+        "icon": "$(circle-outline)"
       },
       {
         "command": "extension.NAMESPACE(node-debug).stopProfile",
         "title": "%profile.stop%",
-        "category": "Debug"
+        "category": "Debug",
+        "icon": "resources/dark/stop-profiling.svg"
       }
     ],
     "menus": {
@@ -276,8 +278,19 @@
         },
         {
           "command": "extension.NAMESPACE(node-debug).startProfile",
-          "icon": "watch",
-          "group": "navigation"
+          "group": "navigation",
+          "when": "debugType == NAMESPACE(chrome) && !jsDebugIsProfiling"
+        },
+        {
+          "command": "extension.NAMESPACE(node-debug).stopProfile",
+          "group": "navigation",
+          "when": "debugType == NAMESPACE(chrome) && jsDebugIsProfiling"
+        }
+      ],
+      "debug/toolBar": [
+        {
+          "command": "extension.NAMESPACE(node-debug).stopProfile",
+          "when": "debugType == NAMESPACE(chrome) && jsDebugIsProfiling"
         }
       ],
       "view/title": [

diff --git a/resources/dark/pause.svg b/resources/dark/pause.svg
diff --git a/resources/dark/stop-profiling.svg b/resources/dark/stop-profiling.svg
diff --git a/src/ui/profiling/uiProfileManager.ts b/src/ui/profiling/uiProfileManager.ts
@@ -127,6 +127,7 @@ export class UiProfileManager implements IDisposable {
   private updateStatusBar() {
     if (this.activeSessions.size === 0) {
       this.statusBarItem?.hide();
+      vscode.commands.executeCommand('setContext', 'jsDebugIsProfiling', false);
       return;
     }
 
@@ -135,6 +136,8 @@ export class UiProfileManager implements IDisposable {
       this.statusBarItem.command = Contributions.StopProfileCommand;
     }
 
+    vscode.commands.executeCommand('setContext', 'jsDebugIsProfiling', true);
+
     if (this.activeSessions.size === 1) {
       const session: UiProfileSession = this.activeSessions.values().next().value;
       this.statusBarItem.text = session.status