Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GLV-SAC method for G2/GT arithmetic. #304

Merged
merged 18 commits into from
Aug 14, 2024
Merged

Implement GLV-SAC method for G2/GT arithmetic. #304

merged 18 commits into from
Aug 14, 2024

Conversation

dfaranha
Copy link
Contributor

No description provided.

@dfaranha dfaranha closed this Aug 14, 2024
static void ep3_mul_glv_imp(ep3_t r, const ep3_t p, const bn_t k) {
int i, j;
size_t l, _l[6];
static void ep3_mul_gls_imp(ep3_t r, const ep3_t p, const bn_t k) {

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 103 lines.
}
for (size_t m = 0; m < (1 << 3); m++) {

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable m hides another variable of the same name (on
line 182
).
ep4_add(r, r, q);
for (size_t i = 0; i < c; i++) {
col = 0;
for (int k = 3; k > 0; k--) {

Check notice

Code scanning / CodeQL

Declaration hides parameter Note

Local variable 'k' hides a
parameter of the same name
.
col += sac[i][k * l + j];
}

for (size_t m = 0; m < (1 << 3); m++) {

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable m hides another variable of the same name (on
line 182
).
}
for (size_t m = 0; m < (1 << 3); m++) {

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable m hides another variable of the same name (on
line 130
).
ep8_add(r, r, q);
for (size_t i = 0; i < c; i++) {
col = 0;
for (int k = 3; k > 0; k--) {

Check notice

Code scanning / CodeQL

Declaration hides parameter Note

Local variable 'k' hides a
parameter of the same name
.
col += sac[i][k * l + j];
}

for (size_t m = 0; m < (1 << 3); m++) {

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable m hides another variable of the same name (on
line 130
).
int8_t c0, n0, *reg = RLC_ALLOCA(int8_t, f * (RLC_FP_BITS + 1));
int8_t *e = RLC_ALLOCA(int8_t, f), *s = RLC_ALLOCA(int8_t, f);
gt_t q, w, *t = RLC_ALLOCA(gt_t, f * RLC_GT_TABLE);
void gt_exp_gls_imp(gt_t c, const gt_t a, const bn_t b, size_t f) {

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 140 lines.
*/
#define RLC_GT_TABLE (1 << (RLC_WIDTH - 2))
static void gt_exp_reg_gls(gt_t c, const gt_t a, const bn_t b, size_t d,

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 114 lines.
bn_null(n);
bn_null(u);

RLC_TRY {

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory Warning

A stack address (
source
) may be assigned to a non-local variable.
@dfaranha dfaranha reopened this Aug 14, 2024
@dfaranha dfaranha merged commit d434fd3 into main Aug 14, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant