create-emty-index - remove FBC opted in operators. #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipoja
requested review from
JAVGan,
chandwanitulsi,
yashvardhannanavati and
xDaile
lipoja
force-pushed
the
create_empty_fbc_optedin
branch
from
0cbc7de to
feb7124
Compare
|
@lipoja, how about we only remove operators from db? Like instead of doing serve from /configs which gives all operators, we do serve from index.db, that will give us non-opted-in operators and we just pass those to opm rm command, Once we migrate, we can ensure /configs is empty and build the index image, wdyt? |
lipoja
force-pushed
the
create_empty_fbc_optedin
branch
3 times, most recently
from
0c10838 to
467ba3a
Compare
lipoja
force-pushed
the
create_empty_fbc_optedin
branch
from
467ba3a to
53d265b
Compare
FBC opted in operator caused opm to fail when removing it because operator was not present in database. If this occurs we try to remove operators once again but we enable permissive mode which silents errors when operator is not present. [CLOUDDST-23683]
lipoja
force-pushed
the
create_empty_fbc_optedin
branch
from
53d265b to
feede62
Compare
yashvardhannanavati
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FBC opted in operator caused opm to fail when removing it because operator was not present in database. If this occurs we try to remove operators once again but we enable permissive mode which silents errors when operator is not present.
[CLOUDDST-23683]