Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OPM port locking mechanism bug #695

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

xDaile
Copy link
Contributor

@xDaile xDaile commented Jun 25, 2024

Related issue: CLOUDDST-23409

Several fixed bugs with the port locking mechanism:

  • Port_file_locks_generator was changed to class. The reason is, that this port_file_locks_generator was throwing an exception (in the right way), however it was very difficult to debug, how and when it was called.
  • Added log messages to better understand the flow of the process
  • in the create_port_filelocks, we create a copy of port_purposes as previously we were working with data-object created when we used \@create_port_filelocks decorator, however, this became a problem once we removed an item from the given array. The next call of this decorated function used the already edited value, which caused problems.
  • we check the create_port_filelocks in the create_port_filelocks even after get_opm_port_stacks call, as there could be a change, that the port_purposes_updated would be empty, so the PortFileLockGenerator would throw an error like "No free port has been found after 0 attempts"

@xDaile
Copy link
Contributor Author

xDaile commented Jun 26, 2024

Related api test run - [JENKINS instance]/iib-api-test/24

@xDaile xDaile merged commit 160c08b into release-engineering:master Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants