Release s3 resources in a timely manner #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashvardhannanavati
force-pushed
the
s3_resources
branch
2 times, most recently
from
b928292 to
3ea09d6
Compare
zanssa
reviewed
May 31, 2024
chandwanitulsi
approved these changes
Jun 11, 2024
lipoja
approved these changes
Jun 18, 2024
yashvardhannanavati
force-pushed
the
s3_resources
branch
2 times, most recently
from
d5f5fcf to
40b0400
Compare
This commit ensures the entire log file is not loaded in-memory and is directly streamed from the s3 bucket Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
yashvardhannanavati
force-pushed
the
s3_resources
branch
from
40b0400 to
c82bb8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures the entire log file is not loaded in-memory and is directly streamed from the s3 bucket