Check if source_from_index is in iib_no_ocp_label_allow_list #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipoja
force-pushed
the
check_source_image
branch
from
7c5a3f4 to
56d6991
Compare
yashvardhannanavati
previously approved these changes
Dec 19, 2023
xDaile
previously approved these changes
Dec 19, 2023
[CLOUDDST-20869]
[CLOUDDST-20869]
lipoja
dismissed stale reviews from xDaile and yashvardhannanavati
via
d7a15a0
lipoja
force-pushed
the
check_source_image
branch
from
56d6991 to
d7a15a0
Compare
xDaile
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrongly assumed that ISV will use overwrite index token and set the check if image is on allow list only for the target (like we do this for bootstraping). However now I know it is not true and this use case slipped my hands. We have to also tests the source index image because the target can be newly created empty index image in our IIB repo.
[CLOUDDST-20869]