Fix object null checks for list envelopes and co-pilot list envelopes #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngl-docusign
approved these changes
Jan 30, 2025
youngl-docusign
approved these changes
Jan 30, 2025
jeremiahsm-docusign
added a commit
that referenced
this pull request
Feb 19, 2025
* Flow-532 * Filters working for most of the cases * Working for status, emailid * remove debuggin lines * Implemented sorting order, Skip and top, folder-Ids * updated the description * Added expiry after in the Add reminder for envelope * Added custom field support * Fixed indendation * Add custom name search field * correct the customFieldName * correct the spell error * Bunmping the release number * Prod branch for DS1006 release created * correct the host name * Update the description * Branding update added * Resend envelope AI enabled * ListEnvelope for sales copilot added * Migrated code from demo to Prod * Undo prod related texts * spell corrections * Update spelling error * fixed the if case at filteredEnvelopes * Remove extra brackets * to and from Date propertiews updates. Resend automatically picks up the Account id * Key sales custom action added * Email summary added * update the connector description to be within character limit. * Prod code updated * Update description of the demo connector. * Descriptions updated to related activities and records * Email summary and Key sales info are tested to be working * Update the description * Update background color to white * swagger updates are made and protocol is filtered for crmOrgURL * Update the description * Check for forward slash and update the parameter * Add recipientGuid. Add TabInfo in the tabs * add decline tab to add tabs action * support all tab types * Read hostURL from the context * Rename the host url methods and optimise the GetEnvelopeURL code * Renaming variables * UpdateDSDemoDescription * Upgrade the version number * FLOW-198 suuport all tab types * remove unused array * FLOW-20 Apply a template * Fix sales copilot Email Summary issue * Updated the description of List envelopes * Hostname changes ported from Prod connector * Update the end date description * FLOW-623 numerical tab field update * FLOW-623 update numerical value field label * FLOW-629 document ID field added to Checkbox groups * get tab info action does not support tab groups * Update the spelling of the associated word * FLOW-608 support sms delivery option * Porting demo code to Prod connector * Changes for adding single document download to Get envelope documents action. * Revert "Changes for adding single document download to Get envelope documents action." * hotfix revert enums in tabs * rebase with young's repo * remove unnecessary change * add missing bracket that was removed when rebasing * prefill tabs logic added * MS.DS1007.11.15.2024.Prod.Hotfix * rebased with dev * prod folder updated * swagger title reverted * Extended GetRecipientFields method to accept Recipient Guid as well * support tab values * FLOW-247-composite-templates * enum added for numerical tabs * syntax error * FLOW-74-bulk-send * remove some changes * revert enum changes * recipient types added * Add recipientId to the Get recipient info from envelope * Audit list event added * additional enhancement * removed manual bulk send * broken down into smaller functions * removed status field * name of the action changed * changes after product review * Composite Templates minor language update * Add radio tab type to Get info tab * composite templates revert operation ID * Added UpdateDocGen method * DocGen feature from harshita-dev * fix the typo in the description * Add error message in the swagger file for the 200 response * Fixing backward compatibility issue * bulk send updates after demo * comments addressed * STRATEGIC-81 add signing group to composite templates * Search List Envelopes action Creates a brand new action based on the exist copilot list envelopes action * STRATEGIC-87 deprecate create envelope with recipients * FLOW-670 add checkbox value to get document tabs * name also added * Content updates for DocGen * Flow-650 add dictionaries for api variable names (#64) * Flow-650 add dictionaries for api variable names * Changes to add new action - start Maestro workflow. * Feature/flow 650 results boolean (#66) * Update wording * Add scopes need for Maestro actions. * STRATEGIC-166 SMS delivery only * email retireved from body instead of query * Changing the nuld_number call method to PUT call * STRATEGIC-90 id verification with EU * description updated * STRATEGIC-162 signing url for in person signer fixed * language update * remove signer email * Feature/STRAT 185 (#73) Content changes for list envelopes and bulk send actions * Code changes to update error message for invalid JWT token. * Update content on signer emial and SMS phone number for "update recipient" action and "add recipient to envelope" action (#76) * Updated the description of Table row and Table name * STRATEGIC-186-hide-recipient-ID-in-embedded-signing-flow * deprecated old action * STRATEGIC-193 update create envelope with recipients and tabs * email body lowercased * language update * ID capitalized * STRATEGIC-192-add-sms-method * Add logic for no signer when grabbing signer name in list envelopes and co-pilot list envelopes * paconn validate fixes * Bugfix/content change (#82) * Update Sender Name * Bulk change items * remove descriptions * add empty string * adding gray text back * paconn validate fixes * Bugfix/content change (#82) * Update Sender Name * Bulk change items * remove descriptions * add empty string * adding gray text back * version bump * Build 8 Prod folder rebase * remove missingInput variable * Fix object null checks for list envelopes and co-pilot list envelopes (#88) * Fix object null checks for list envelopes and co-pilot list envelopes --------- Co-authored-by: Harshita Vinnakota <harshita.vinnakota@docusign.com> Co-authored-by: harshitav-docusign <118772192+harshitav-docusign@users.noreply.github.com> Co-authored-by: release-docusign <126611882+release-docusign@users.noreply.github.com> Co-authored-by: DOCUSIGNHQ\Prashanth.Bachu <prashanth.bachu@docusign.com> Co-authored-by: prashanthb-docusign <prashanth.bachu@dsxtr.com> Co-authored-by: jeremiahs-docusign <jeremiah.smith@docusign.com>
jeremiahsm-docusign
added a commit
that referenced
this pull request
Feb 20, 2025
* Flow-532 * Filters working for most of the cases * Working for status, emailid * remove debuggin lines * Implemented sorting order, Skip and top, folder-Ids * updated the description * Added expiry after in the Add reminder for envelope * Added custom field support * Fixed indendation * Add custom name search field * correct the customFieldName * correct the spell error * Bunmping the release number * Prod branch for DS1006 release created * correct the host name * Update the description * Branding update added * Resend envelope AI enabled * ListEnvelope for sales copilot added * Migrated code from demo to Prod * Undo prod related texts * spell corrections * Update spelling error * fixed the if case at filteredEnvelopes * Remove extra brackets * to and from Date propertiews updates. Resend automatically picks up the Account id * Key sales custom action added * Email summary added * update the connector description to be within character limit. * Prod code updated * Update description of the demo connector. * Descriptions updated to related activities and records * Email summary and Key sales info are tested to be working * Update the description * Update background color to white * swagger updates are made and protocol is filtered for crmOrgURL * Update the description * Check for forward slash and update the parameter * Add recipientGuid. Add TabInfo in the tabs * add decline tab to add tabs action * support all tab types * Read hostURL from the context * Rename the host url methods and optimise the GetEnvelopeURL code * Renaming variables * UpdateDSDemoDescription * Upgrade the version number * FLOW-198 suuport all tab types * remove unused array * FLOW-20 Apply a template * Fix sales copilot Email Summary issue * Updated the description of List envelopes * Hostname changes ported from Prod connector * Update the end date description * FLOW-623 numerical tab field update * FLOW-623 update numerical value field label * FLOW-629 document ID field added to Checkbox groups * get tab info action does not support tab groups * Update the spelling of the associated word * FLOW-608 support sms delivery option * Porting demo code to Prod connector * Changes for adding single document download to Get envelope documents action. * Revert "Changes for adding single document download to Get envelope documents action." * hotfix revert enums in tabs * rebase with young's repo * remove unnecessary change * add missing bracket that was removed when rebasing * prefill tabs logic added * MS.DS1007.11.15.2024.Prod.Hotfix * rebased with dev * prod folder updated * swagger title reverted * Extended GetRecipientFields method to accept Recipient Guid as well * support tab values * FLOW-247-composite-templates * enum added for numerical tabs * syntax error * FLOW-74-bulk-send * remove some changes * revert enum changes * recipient types added * Add recipientId to the Get recipient info from envelope * Audit list event added * additional enhancement * removed manual bulk send * broken down into smaller functions * removed status field * name of the action changed * changes after product review * Composite Templates minor language update * Add radio tab type to Get info tab * composite templates revert operation ID * Added UpdateDocGen method * DocGen feature from harshita-dev * fix the typo in the description * Add error message in the swagger file for the 200 response * Fixing backward compatibility issue * bulk send updates after demo * comments addressed * STRATEGIC-81 add signing group to composite templates * Search List Envelopes action Creates a brand new action based on the exist copilot list envelopes action * STRATEGIC-87 deprecate create envelope with recipients * FLOW-670 add checkbox value to get document tabs * name also added * Content updates for DocGen * Flow-650 add dictionaries for api variable names (#64) * Flow-650 add dictionaries for api variable names * Changes to add new action - start Maestro workflow. * Feature/flow 650 results boolean (#66) * Update wording * Add scopes need for Maestro actions. * STRATEGIC-166 SMS delivery only * email retireved from body instead of query * Changing the nuld_number call method to PUT call * STRATEGIC-90 id verification with EU * description updated * STRATEGIC-162 signing url for in person signer fixed * language update * remove signer email * Feature/STRAT 185 (#73) Content changes for list envelopes and bulk send actions * Code changes to update error message for invalid JWT token. * Update content on signer emial and SMS phone number for "update recipient" action and "add recipient to envelope" action (#76) * Updated the description of Table row and Table name * STRATEGIC-186-hide-recipient-ID-in-embedded-signing-flow * deprecated old action * STRATEGIC-193 update create envelope with recipients and tabs * email body lowercased * language update * ID capitalized * STRATEGIC-192-add-sms-method * Add logic for no signer when grabbing signer name in list envelopes and co-pilot list envelopes * paconn validate fixes * Bugfix/content change (#82) * Update Sender Name * Bulk change items * remove descriptions * add empty string * adding gray text back * paconn validate fixes * Bugfix/content change (#82) * Update Sender Name * Bulk change items * remove descriptions * add empty string * adding gray text back * version bump * Build 8 Prod folder rebase * remove missingInput variable * Fix object null checks for list envelopes and co-pilot list envelopes (#88) * Fix object null checks for list envelopes and co-pilot list envelopes --------- Co-authored-by: Harshita Vinnakota <harshita.vinnakota@docusign.com> Co-authored-by: harshitav-docusign <118772192+harshitav-docusign@users.noreply.github.com> Co-authored-by: release-docusign <126611882+release-docusign@users.noreply.github.com> Co-authored-by: DOCUSIGNHQ\Prashanth.Bachu <prashanth.bachu@docusign.com> Co-authored-by: prashanthb-docusign <prashanth.bachu@dsxtr.com> Co-authored-by: jeremiahs-docusign <jeremiah.smith@docusign.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed any potential null pointers for the list envelopes and co-pilot list envelopes actions. Also sped up runtimes for string concatenation to use stringbuilder.
Strategic-228
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json, by runningpaconn validatecommand.apiProperties.jsonhas a valid brand color and doesn't use an invalid brand color,#007ee5or#ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: