Skip to content

Conversation

@1-leo
Copy link
Contributor

@1-leo 1-leo commented Dec 5, 2025

No description provided.

@1-leo
Copy link
Contributor Author

1-leo commented Dec 5, 2025

  • signers now return a event because its immutable
  • => problem in NdkBroadcastResponse because publishEvent need to be a future TBD
  • check AuthEvent extend
  • check ZapRequest extend

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 91.76955% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.24%. Comparing base (f368849) to head (052b634).

Files with missing lines Patch % Lines
...ses/nip_01_event_service/nip_01_event_service.dart 86.48% 5 Missing ⚠️
...in_layer/usecases/proof_of_work/proof_of_work.dart 60.00% 4 Missing ⚠️
...layer/repositories/signers/nip46_event_signer.dart 0.00% 3 Missing ⚠️
...ndk/lib/domain_layer/usecases/bunkers/bunkers.dart 0.00% 3 Missing ⚠️
.../ndk/lib/data_layer/models/nip_01_event_model.dart 98.38% 1 Missing ⚠️
...ayer/repositories/signers/bip340_event_signer.dart 50.00% 1 Missing ⚠️
...layer/usecases/files/blossom_user_server_list.dart 0.00% 1 Missing ⚠️
...ackages/ndk/lib/domain_layer/usecases/nwc/nwc.dart 0.00% 1 Missing ⚠️
packages/ndk/lib/shared/nips/nip13/nip13.dart 93.75% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           fix-websocket-performance-issues-2     #332      +/-   ##
======================================================================
+ Coverage                               70.87%   71.24%   +0.37%     
======================================================================
  Files                                     139      142       +3     
  Lines                                    5157     5238      +81     
======================================================================
+ Hits                                     3655     3732      +77     
- Misses                                   1502     1506       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo 1-leo requested review from frnandu and nogringo December 6, 2025 10:34
@1-leo
Copy link
Contributor Author

1-leo commented Dec 6, 2025

@frnandu
We have this in both our engines with the refactor, the not signed event is returned.
I think the best way forward is to return a future (with a completer), but this would require more refactoring on all the clients...
What do you think?

grafik grafik

@1-leo
Copy link
Contributor Author

1-leo commented Dec 6, 2025

  • refactor nip13 to non static (object model)
  • isolate without Singleton? As usecase

@1-leo 1-leo self-assigned this Dec 6, 2025
@1-leo 1-leo added this to ndk-dev Dec 6, 2025
@1-leo 1-leo moved this to In Progress in ndk-dev Dec 6, 2025
@1-leo 1-leo added the refactor label Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants