EventQueue fixes #163
Merged
EventQueue fixes #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meling
requested changes
Jan 15, 2025
eventloop/eventloop.go
Outdated
| // run handlers with runInAddEvent option | ||
| el.processEvent(event, true) | ||
| el.eventQ.push(event) | ||
| dropped := el.eventQ.push(event) |
Member
There was a problem hiding this comment.
See details below...
droppedEvent := el.eventQ.push(event)
if droppedEvent != nil {
el.logger.Warnf("event queue is full, dropped event: %v", droppedEvent)
}
Since queue.push() can drop events, we instead return the dropped event so that we can log it...
meling
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154
This PR improves the documentation of the event queue implementation, fixes an invalid check, and adds a warning log when the event queue is full.
All tests pass and things run as intended. Though it would be nice open an issue for stress testing the event queue further.