Skip to content

Fix eddsa private key parsing bug #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meling merged 2 commits into from
Mar 12, 2024
Merged

Fix eddsa private key parsing bug #123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8f5c48
fix(eddsa): Fix eddsa private key parsing bug
hanish520 Mar 10, 2024
18716fd
fix(eddsa): addressed review comments
hanish520 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crypto/keygen/keygen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,15 @@ func ParsePrivateKey(buf []byte) (key hotstuff.PrivateKey, err error) {
case ecdsacrypto.PrivateKeyFileType:
key, err = x509.ParseECPrivateKey(b.Bytes)
case eddsa.PrivateKeyFileType:
key = ed25519.NewKeyFromSeed(b.Bytes[:32])
genericKey, err := x509.ParsePKCS8PrivateKey(b.Bytes)
if err != nil {
return nil, err
}
var ok bool
key, ok = genericKey.(ed25519.PrivateKey)
if !ok {
return nil, fmt.Errorf("failed to parse key")
}
case bls12.PrivateKeyFileType:
k := &bls12.PrivateKey{}
k.FromBytes(b.Bytes)
Expand Down