merging master back in #4
Merged
+174
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* do not filter validation data * minimum length in filter is now actually minimum length, sensible defaults for maximum sequence length in build_dataset * add option for optionally filtering validation data
Fix `AttributeError: 'Optimizer' object has no attribute 'params'`
* use torchaudio.legacy.load
* Fix comments in AAN module
Update optimizers.py
* simplify lazily_load_dataset, remove incorrect documentation * remove one lazily_load_dataset call * dataset loading to build_dataset_iter * move nested function, remove incorrect documentation * begin refactoring DatasetLazyIter * fix flake8 * refactor DatasetLazyIter * update doc * remove train_iter_fct, valid_iter_fct
…es (#1136) * do not write temporary shard files * add shard size assert * unify expectations of input files and iterators across datasets * fix argument signature
* Simplify multi headed attention
bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.