-
Notifications
You must be signed in to change notification settings - Fork 0
fix csv file names #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix csv file names #141
Conversation
|
This works. The only thing I noticed when I tried it is that the tables from R, L and C pages all save as just the cell type name. I updated the filename again to include the |
|
Thanks, that looks good. I was wondering, if we should encode the state somehow in the filename as well? For example, if you filter by a certain text connection strength, then the downloaded file contains a subset of what the file promises. Or do we leave that up to the user? |
|
I think this could be a good idea. I'll look into it. |
|
This should be included in the most recent commit. I've also updated the ROI table's filename too. At the moment the minimum number of connections or percentage (for the ROI table) is included in the filename with a decimal point. I was debating whether to change this to a dash, but the decimal point doesn't seem to cause a problem. I can update it if you think it would be better though. |
|
That would not include the sort order, would it? At this point I am almost leaning towards a more simple file name. |
|
I don't think the sorting order really matters because the user can resort the data afterwards, but the data in the table is determined by the slider value so I think that's worth including. I have added a named function in the most recent commit. |
This should fix #130