Skip to content

Conversation

@floesche
Copy link
Member

This should fix #130

@floesche floesche requested a review from leburnett November 26, 2025 22:30
@floesche floesche self-assigned this Nov 26, 2025
@leburnett
Copy link
Collaborator

This works. The only thing I noticed when I tried it is that the tables from R, L and C pages all save as just the cell type name. I updated the filename again to include the soma_side so now it saves as "downstream_partners_output_Tm3_combined". or "downstream_partners_output_Tm3_right" etc. If you can think of a reason why we shouldn't do this feel free to revert.

@floesche
Copy link
Member Author

floesche commented Dec 1, 2025

Thanks, that looks good. I was wondering, if we should encode the state somehow in the filename as well? For example, if you filter by a certain text connection strength, then the downloaded file contains a subset of what the file promises. Or do we leave that up to the user?

@leburnett
Copy link
Collaborator

I think this could be a good idea. I'll look into it.

@leburnett
Copy link
Collaborator

This should be included in the most recent commit. I've also updated the ROI table's filename too. At the moment the minimum number of connections or percentage (for the ROI table) is included in the filename with a decimal point. I was debating whether to change this to a dash, but the decimal point doesn't seem to cause a problem. I can update it if you think it would be better though.

@floesche
Copy link
Member Author

floesche commented Dec 2, 2025

That would not include the sort order, would it? At this point I am almost leaning towards a more simple file name.
If we want to keep the more complicated, it might be useful to use a named function instead of 3 anonymous functions that all do the exact same thing.

@leburnett
Copy link
Collaborator

leburnett commented Dec 2, 2025

I don't think the sorting order really matters because the user can resort the data afterwards, but the data in the table is determined by the slider value so I think that's worth including. I have added a named function in the most recent commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different names for connectivity tables when downloaded

3 participants