Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while uploading file to webserver #13

Open
phbaars opened this issue Nov 29, 2019 · 9 comments
Open

Error while uploading file to webserver #13

phbaars opened this issue Nov 29, 2019 · 9 comments

Comments

@phbaars
Copy link

phbaars commented Nov 29, 2019

While uploading a file (big_bug_bunny or whatever other file) there is an error:
Video should have an AVC (h264) encoding.
Another missing Gstreamer module perhaps?

@phbaars
Copy link
Author

phbaars commented Dec 1, 2019

Solved this one. Parameter .codec in MediaInfo is depricated. Change the line in web_server.py:
if video_track.codec != 'AVC': in
if video_track.codec_id != 'avc1':
ans uploading works again.

@reinzor
Copy link
Owner

reinzor commented Dec 1, 2019

Could you create a PR for this?

@phbaars
Copy link
Author

phbaars commented Dec 1, 2019

What is a PR ?
If it is a new release then later, because there is so much to do.
-Adding sound is top priority.
-Synchronisation often fails, needs solving.
-Tiles cannot overlap. Very annoying.
-Cannot save/restore tile information.
-Solve the issue that smaller videos do not work on the tiles.

@reinzor
Copy link
Owner

reinzor commented Dec 1, 2019

A pull request : https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests

I can help you with the giving pointers for the implementation but I do not have the time to implement these features myself.

@phbaars
Copy link
Author

phbaars commented Dec 1, 2019

I am new to github and I am not sure how to do a PR. Will read about it this evening.
Please give hints about the points I mentioned before.
An additional question: how are the files transferred to the clients? Does the server push or does the client pull? So far I copied the files op the client by memstick.

@reinzor
Copy link
Owner

reinzor commented Dec 1, 2019

-Adding sound is top priority.

Could be added to client or server. For the server, a server pipeline should be added with audio sink:
https://github.com/reinzor/videowall/blob/master/src/videowall/player/player_server.py . For the client, only a audio sink should be added here: https://github.com/reinzor/videowall/blob/master/src/videowall/player/player_client.py#L51

-Synchronisation often fails, needs solving.

What issues are you experiencing?

-Tiles cannot overlap. Very annoying.

This is by design, the backend is not limited but the front-end is putting this constraint. We could alter the vue front-end code here: https://github.com/reinzor/videowall/blob/master/web/src/components/ScreenGrid.vue

-Cannot save/restore tile information.

Could be added as userdata on the web interface: https://github.com/reinzor/videowall/tree/master/web

-Solve the issue that smaller videos do not work on the tiles.

What are you are experiencing exactly? The application is designed only for 720p videos but smaller videos should work aswell.

If you are going to work on this, please split these in separate issues with attached PR's so that we can discuss these separately.

@phbaars
Copy link
Author

phbaars commented Dec 1, 2019

Synchronisation: if one of the screens gets out of sync then the system will not sync again. Question: Does the systen sync at start of the file or everey Vsync?
Small videos: in a 640x480 video with 2 same-size monitors the clients will not start at all. With one tile say 400x300 there will be an extremely zoomed-in picture not related to the tile.

@reinzor
Copy link
Owner

reinzor commented Dec 2, 2019

For synchronization the gstreamer netclient clock is used: https://gstreamer.freedesktop.org/documentation/net/gstnetclientclock.html?gi-language=c

Please create separate issues for the separate issues you encounter so we can track these better instead of this long thread ;). Also, if you encounter an issue, provide an example or video so that someone else can reproduce your issue. Thanks :).

@reinzor
Copy link
Owner

reinzor commented Dec 2, 2019

As for the filetransfer, rsync is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants