fixed invoking URL dead locks app

reignstudios · Nov 23, 2017 · 1241c13 · 1241c13
1 parent c41a535
commit 1241c13
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 17 deletions.
diff --git a/GitCommander/Properties/AssemblyInfo.cs b/GitCommander/Properties/AssemblyInfo.cs
@@ -37,7 +37,7 @@
 
 public static class VersionInfo
 {
-	public const string version = "1.0.2";
+	public const string version = "1.0.3";
 
 	#if DEBUG
 	public const string versionType = version + "d";

diff --git a/GitItGUI.Core/AppManager.cs b/GitItGUI.Core/AppManager.cs
@@ -397,18 +397,14 @@ private static bool IsValidVersion(string currentVersion, string requiredVersion
 
 		private static void DownloadGit()
 		{
-			using (var process = Process.Start("https://git-scm.com/downloads"))
-			{
-				process.WaitForExit();
-			}
+			var process = Process.Start("https://git-scm.com/downloads");
+			process.Dispose();
 		}
 
 		private static void DownloadGitLFS()
 		{
-			using (var process = Process.Start("https://git-lfs.github.com/"))
-			{
-				process.WaitForExit();
-			}
+			var process = Process.Start("https://git-lfs.github.com/");
+			process.Dispose();
 		}
 
 		private static void Client_DownloadStringCompleted(object sender, DownloadStringCompletedEventArgs e)
@@ -445,7 +441,7 @@ private static void Client_DownloadStringCompleted(object sender, DownloadString
 							canCheckAppVersion = false;
 							if (!IsValidVersion(VersionInfo.version, xmlReader.ReadInnerXml()))
 							{
-								DebugLog.LogError("Your 'Git-It-GUI' version is out of date.");
+								DebugLog.LogWarning("Your 'Git-It-GUI' version is out of date.");
 								if (checkForUpdatesCallback != null) checkForUpdatesCallback(UpdateCheckResult.AppVersionOutOfDate);
 							}
 						}

diff --git a/GitItGUI.UI/Screens/StartScreen.xaml.cs b/GitItGUI.UI/Screens/StartScreen.xaml.cs
@@ -154,10 +154,8 @@ private void settingsButton_Click(object sender, RoutedEventArgs e)
 
 		private void UpdateImage_MouseUp(object sender, System.Windows.Input.MouseButtonEventArgs e)
 		{
-			using (var process = Process.Start("https://github.com/reignstudios/Git-It-GUI/releases"))
-			{
-				process.WaitForExit();
-			}
+			var process = Process.Start("https://github.com/reignstudios/Git-It-GUI/releases");
+			process.Dispose();
 		}
 	}
 }
diff --git a/GitItGUI.UI/VersionInfo.xml b/GitItGUI.UI/VersionInfo.xml
@@ -1,4 +1,4 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <VersionInfo>
-	<AppVersion>1.0.2</AppVersion>
+	<AppVersion>1.0.3</AppVersion>
 </VersionInfo>
diff --git a/Installer/Git-It-GUI_Installer.aip b/Installer/Git-It-GUI_Installer.aip
@@ -13,10 +13,10 @@
     <ROW Property="ARPURLUPDATEINFO" Value="https://github.com/reignstudios/Git-It-GUI/releases"/>
     <ROW Property="CTRLS" Value="2"/>
     <ROW Property="Manufacturer" Value="Reign-Studios"/>
-    <ROW Property="ProductCode" Value="1033:{89F43A32-6EB1-47F7-B70F-973722337156} " Type="16"/>
+    <ROW Property="ProductCode" Value="1033:{48C9618C-B4B4-4480-A47B-5D29516DB5D9} " Type="16"/>
     <ROW Property="ProductLanguage" Value="1033"/>
     <ROW Property="ProductName" Value="Git-It-GUI"/>
-    <ROW Property="ProductVersion" Value="1.0.2" Type="32"/>
+    <ROW Property="ProductVersion" Value="1.0.3" Type="32"/>
     <ROW Property="RUNAPPLICATION" Value="1" Type="4"/>
     <ROW Property="SecureCustomProperties" Value="OLDPRODUCTS;AI_NEWERPRODUCTFOUND"/>
     <ROW Property="UpgradeCode" Value="{FD4A5E78-F668-42CE-90BC-D1DDAA792189}"/>