Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test update sig rules #35

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Test update sig rules #35

merged 5 commits into from
Feb 23, 2024

Conversation

mfebrizio
Copy link
Collaborator

TRY 2: Identical pull request to #33.

Tested functionality of updating es, sig, and cumulative es rule data. Made minor code adjustments. Added (identical) environment.yml for each script.

slightly cleaner printed output
replaced datetime with date format, since we don't need time level info; adjusted input prompt to add space and be consistent with expected input
@mfebrizio mfebrizio added the enhancement New feature or request label Feb 23, 2024
@mfebrizio mfebrizio requested a review from zhoudanxie February 23, 2024 15:44
Copy link
Collaborator

@zhoudanxie zhoudanxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@zhoudanxie zhoudanxie merged commit 4656d57 into main Feb 23, 2024
@zhoudanxie zhoudanxie deleted the test_update_sig_rules branch February 23, 2024 17:12
@mfebrizio mfebrizio added the code review Code review requested label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Code review requested enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants