Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format not solvable error messages #1886

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Conversation

jaimergp
Copy link
Contributor

Comes from https://matrix.to/#/!mPxkHLLyiXutAGtuaf:gitter.im/$0AVaD6APc2TPw1OsZoEPH76C86zjexoe1tV0gTTssxQ?via=gitter.im&via=matrix.org

The current output is a bit unreadable:

image

This hopefully improves it a bit.

@jaimergp
Copy link
Contributor Author

Currently trying to reproduce by hand on the HTML canvas. Wait before merge.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c021530) 68.65% compared to head (cfb2452) 68.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
+ Coverage   68.65%   68.80%   +0.15%     
==========================================
  Files          93       93              
  Lines        8769     8754      -15     
==========================================
+ Hits         6020     6023       +3     
+ Misses       2749     2731      -18     
Files Coverage Δ
conda_forge_tick/auto_tick.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaimergp
Copy link
Contributor Author

This is more or less what it should look like, to the best of my manual HTML edition abilities:

Collapsed:

image

Revealed:

image

I can't use <summary> because for some reason the triangle toggle is missing 🤷 I guess it's been overridden by some CSS rule in the site, but current approach works well enough.

@beckermr
Copy link
Contributor

Where does the newline before the details tag come from? Can we remove it?

@beckermr
Copy link
Contributor

Ohh nvm this might not be in the final thing. LGTM!

@beckermr beckermr enabled auto-merge (squash) October 10, 2023 12:44
@beckermr
Copy link
Contributor

Ideally we should do this formatting in the front-end and not here. That is my bug and I will try to fix it at some point.

@jaimergp
Copy link
Contributor Author

Ideally we should do this formatting in the front-end and not here

Agreed, something more structured would be better (e.g. a platform-to-error dict instead of the list of str) and would allow for a nicer collection of collapsible blocks. I'm not happy with the align=left stuff either here, we can move that to the status site if you want.

auto-merge was automatically disabled October 10, 2023 14:27

Head branch was pushed to by a user without write access

@jaimergp
Copy link
Contributor Author

Ideally we would have something like:

- vpri["new_version_errors"][_new_ver] = _solver_err_str
+ vpri["new_version_errors"][_new_ver] = {
+     "error_type": "not solvable",
+     "job_url": os.getenv("CIRCLE_BUILD_URL"),
+     "base_branch": base_branch,
+     "messages": {
+          "platform_identifier": "string of problems",
+          ...
+     },
+ }

@jaimergp
Copy link
Contributor Author

Where does the newline before the details tag come from?

I think that's the default details block formatting. We can't customize the title with a summary because the style has been overridden in the frontend somehow.

@beckermr
Copy link
Contributor

Yolo.

@beckermr beckermr merged commit f48ca08 into regro:master Oct 10, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants