-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format not solvable error messages #1886
Conversation
Currently trying to reproduce by hand on the HTML canvas. Wait before merge. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1886 +/- ##
==========================================
+ Coverage 68.65% 68.80% +0.15%
==========================================
Files 93 93
Lines 8769 8754 -15
==========================================
+ Hits 6020 6023 +3
+ Misses 2749 2731 -18
☔ View full report in Codecov by Sentry. |
Where does the newline before the details tag come from? Can we remove it? |
Ohh nvm this might not be in the final thing. LGTM! |
Ideally we should do this formatting in the front-end and not here. That is my bug and I will try to fix it at some point. |
Agreed, something more structured would be better (e.g. a platform-to-error dict instead of the list of str) and would allow for a nicer collection of collapsible blocks. I'm not happy with the align=left stuff either here, we can move that to the |
Head branch was pushed to by a user without write access
Ideally we would have something like: - vpri["new_version_errors"][_new_ver] = _solver_err_str
+ vpri["new_version_errors"][_new_ver] = {
+ "error_type": "not solvable",
+ "job_url": os.getenv("CIRCLE_BUILD_URL"),
+ "base_branch": base_branch,
+ "messages": {
+ "platform_identifier": "string of problems",
+ ...
+ },
+ } |
I think that's the default |
Yolo. |
Comes from https://matrix.to/#/!mPxkHLLyiXutAGtuaf:gitter.im/$0AVaD6APc2TPw1OsZoEPH76C86zjexoe1tV0gTTssxQ?via=gitter.im&via=matrix.org
The current output is a bit unreadable:
This hopefully improves it a bit.