Skip to content

Commit

Permalink
PROD run long-term migrations last
Browse files Browse the repository at this point in the history
  • Loading branch information
beckermr committed May 16, 2024
1 parent fbd825f commit c29146c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
9 changes: 7 additions & 2 deletions conda_forge_tick/make_migrators.py
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,7 @@ def load_migrators() -> MutableSequence[Migrator]:
migrators = []
version_migrator = None
pinning_migrators = []
longterm_migrators = []
all_names = get_all_keys_for_hashmap("migrators")
with executor("process", 4) as pool:
futs = [pool.submit(_load, name) for name in all_names]
Expand All @@ -703,15 +704,19 @@ def load_migrators() -> MutableSequence[Migrator]:
elif isinstance(migrator, MigrationYamlCreator) or isinstance(
migrator, MigrationYaml
):
pinning_migrators.append(migrator)
if getattr(migrator, "longterm", False):
longterm_migrators.append(migrator)
else:
pinning_migrators.append(migrator)
else:
migrators.append(migrator)

if version_migrator is None:
raise RuntimeError("No version migrator found in the migrators directory!")

random.shuffle(pinning_migrators)
migrators = [version_migrator] + migrators + pinning_migrators
random.shuffle(longterm_migrators)
migrators = [version_migrator] + migrators + pinning_migrators + longterm_migrators

return migrators

Expand Down
3 changes: 3 additions & 0 deletions conda_forge_tick/migrators/migration_yaml.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def __init__(
ignored_deps_per_node=None,
max_solver_attempts=3,
effective_graph: nx.DiGraph = None,
longterm=False,
**kwargs: Any,
):
if not hasattr(self, "_init_args"):
Expand All @@ -156,6 +157,7 @@ def __init__(
"ignored_deps_per_node": ignored_deps_per_node,
"max_solver_attempts": max_solver_attempts,
"effective_graph": effective_graph,
"longterm": longterm,
}
self._init_kwargs.update(copy.deepcopy(kwargs))

Expand Down Expand Up @@ -198,6 +200,7 @@ def __init__(
self.pr_limit = 5
self.bump_number = bump_number
self.max_solver_attempts = max_solver_attempts
self.longterm = longterm

self._reset_effective_graph()

Expand Down

0 comments on commit c29146c

Please sign in to comment.