Skip to content

Conversation

kgilmer
Copy link
Member

@kgilmer kgilmer commented May 2, 2024

Avoid global error on bar on targets without batteries on jammy.

config.toml Outdated
# format_mem = "{mem_used_percents}"
# format_swap = "{swap_used_percents}"

[[block]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the section that needs to be disabled I guess?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

Copy link
Contributor

@SoumyaRanjanPatnaik SoumyaRanjanPatnaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SoumyaRanjanPatnaik
Copy link
Contributor

I wonder if the patch you were trying to implement on i3status-rs (that allowed input from stdin) worked?! That would have made it easier to customize...

@kgilmer
Copy link
Member Author

kgilmer commented May 3, 2024

I wonder if the patch you were trying to implement on i3status-rs (that allowed input from stdin) worked?! That would have made it easier to customize...

Yeah I haven't gotten back to that patch after the concern you raised. Would there be a simple way to determine if there is a problem or not? Send a specific signal to the process and see if it restarts?

@SoumyaRanjanPatnaik
Copy link
Contributor

Ohh right. I remember now. Let's try it out. Worst case, we add a flag to the state that checks if the configs have to be reinitialized.

@SoumyaRanjanPatnaik
Copy link
Contributor

You can go ahead with the merge if you'd like. I'll try to figure out if it's possible to load configurations from stdin at runtime without losing out on functionality.

@kgilmer kgilmer merged commit c9a72e7 into ubuntu/v0.22.0 May 4, 2024
@kgilmer kgilmer deleted the fix-disable-battery branch May 4, 2024 15:35
@SoumyaRanjanPatnaik SoumyaRanjanPatnaik restored the fix-disable-battery branch June 20, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants