Closed
Conversation
alaric-rd
force-pushed
the
value-formats
branch
from
5facd9a to
b49759e
Compare
rossjones
approved these changes
Sep 25, 2025
Contributor
rossjones
left a comment
rossjones
left a comment
There was a problem hiding this comment.
Couple of suggestions, but I think it's looking good. Not sure whether the formats page should show all of the fields as it gets a bit cluttered and hard to see the actual thing I need to do on the page for sheets like the pensions sample.
Still to do: - Skip the format selection step if it's not needed - Improve text on the format selection step - Use guessed types to preselect formats if we can
…pes require formats
Includes a few bug fixes to the guesser!
alaric-rd
force-pushed
the
value-formats
branch
from
647f51d to
d387fa5
Compare
…safe" and "maybe" options "Safe" options are valid for EVERY value in the column. "Maybe" options are valid for SOME values in the column (but not every). The frontend needs update to reflect this distinction, only showing safe/maybe options (rather than ALL options as currently).
Member
|
Is the PR done with now? |
Contributor
Author
|
Yes, sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Herein is work to give the UI a way to select formats for columns that need them.
The playwright tests are failing with a timeout - I can't run them locally so I'm not sure what they're upset about; adding an extra step to processes they click through, resulting in some expected button never turning up, might well be the problem. Guidance welcome!