address review comments

x/ecocredit/basket/msg_create.go

@@ -102,10 +102,6 @@ func validateDateCriteria(d *DateCriteria) error {
 		if startDateWindow.Seconds < 24*3600 {
 			return errBadReq.Wrap("date_criteria.start_date_window must be at least 1 day")
 		}
-	} else if yearsInThePast != 0 {
-		// continue
-	} else {
-		return errBadReq.Wrapf("unsupported date_criteria value %v", d)
 	}
 	return nil
 }

x/ecocredit/basket/msg_create_test.go

@@ -47,7 +47,7 @@ func TestMsgCreateValidateBasic(t *testing.T) {
 		{"name-short",
 			MsgCreate{Curator: a, Name: randstr.String(nameMinLen - 1)},
 			"name must start with an alphabetic character"},
-		{"name-no-alpahnum",
+		{"name-no-alphanum",
 			MsgCreate{Curator: a, Name: randstr.String(nameMinLen) + "*"},
 			"name must start with an alphabetic character"},
 		{"name-no-alpah-prefix",
@@ -59,15 +59,12 @@ func TestMsgCreateValidateBasic(t *testing.T) {
 		{"exponent-2",
 			MsgCreate{Curator: a, Name: name, Exponent: 17},
 			"exponent must be one of [0 1 2 3 6 9 12 15 18 21 24]"},
-		{"credity_type-1",
+		{"credit_type-1",
 			MsgCreate{Curator: a, Name: name, Exponent: 3},
 			"credit type abbreviation must be 1-3"},
-		{"credity_type-2",
+		{"credit_type-2",
 			MsgCreate{Curator: a, Name: name, Exponent: 3, CreditTypeAbbrev: randstr.String(creditTypeAbbrMaxLen + 1)},
 			"credit type abbreviation must be 1-3"},
-		{"date_criteria-1",
-			MsgCreate{Curator: a, Name: name, Exponent: 3, CreditTypeAbbrev: creditAbbr, DateCriteria: &DateCriteria{}},
-			"unsupported date_criteria value"},
 		{"description",
 			MsgCreate{Curator: a, Name: name, Exponent: 3, CreditTypeAbbrev: creditAbbr, DateCriteria: start, Description: randstr.String(descrMaxLen + 1)},
 			"description can't be longer"},
@@ -102,33 +99,18 @@ func TestMsgCreateValidateDateCriteria(t *testing.T) {
 		d   DateCriteria
 		err string
 	}{
-		{
-			"nil-min_start_date",
-			DateCriteria{MinStartDate: nil},
-			"unsupported date_criteria value",
-		},
 		{
 			"bad-min_start_date",
 			DateCriteria{MinStartDate: &gogotypes.Timestamp{
 				Seconds: time.Date(1400, 1, 1, 0, 0, 0, 0, time.UTC).Unix()},
 			},
 			"date_criteria.min_start_date must be after",
 		},
-		{
-			"nil-start_date_window",
-			DateCriteria{StartDateWindow: nil},
-			"unsupported date_criteria value",
-		},
 		{
 			"bad-start_date_window",
 			DateCriteria{StartDateWindow: &gogotypes.Duration{Seconds: 3600}},
 			"date_criteria.start_date_window must be at least 1 day",
 		},
-		{
-			"zero-years_in_the_past",
-			DateCriteria{YearsInThePast: 0},
-			"unsupported date_criteria value",
-		},
 		{
 			"both-min_start_date-start_date_window-set",
 			DateCriteria{

x/ecocredit/features/basket/create.feature

@@ -108,8 +108,3 @@ Feature: Create Basket
     When user tries to create a basket
     And user provides a minimum start date that is less than 1 day
     Then basket is NOT created
-
-  Scenario: basket years in the past must be a positive integer
-    When user tries to create a basket
-    And user provides years in the past that is less than 1
-    Then basket is NOT created