Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update proto revision comments #1871

Merged
merged 6 commits into from
Mar 29, 2023
Merged

Conversation

ryanchristo
Copy link
Member

Description

Ref: #1855

This pull request updates the proto revision comments to align with the latest releases.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo mentioned this pull request Mar 28, 2023
27 tasks
@ryanchristo ryanchristo marked this pull request as ready for review March 28, 2023 18:39
@ryanchristo ryanchristo requested a review from a team March 28, 2023 18:39
@ryanchristo
Copy link
Member Author

Incident with actions: https://www.githubstatus.com/

@ryanchristo ryanchristo merged commit 633f232 into main Mar 29, 2023
@ryanchristo ryanchristo deleted the ryan/update-proto-docs branch March 29, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants