Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix cmd test temp directory #1813

Merged
merged 1 commit into from
Mar 8, 2023
Merged

test: fix cmd test temp directory #1813

merged 1 commit into from
Mar 8, 2023

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Mar 7, 2023

Description

When we updated to go 1.19, we received deprecation errors that required updating io/ioutil to os. The use of temporary directory was not properly set up for one of the tests and therefore the test fails with the error genesis.json already exists when tests are run more than once locally. This pull request fixes the issue.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review March 7, 2023 17:12
@ryanchristo ryanchristo requested a review from a team March 7, 2023 17:12
@ryanchristo ryanchristo merged commit 7404e1b into main Mar 8, 2023
@ryanchristo ryanchristo deleted the ryan/fix-cmd-test branch March 8, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants