Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build): migrate goreleaser setup to use goreleaser-cross #1733

Merged
merged 11 commits into from
Jan 11, 2023

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jan 9, 2023

Description

Closes: #1698


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 changed the title ci(build): setup goreleaser-cross ci(build): migrate goreleaser setup to use goreleaser-cross Jan 9, 2023
@aleem1314 aleem1314 marked this pull request as ready for review January 9, 2023 14:57
@aleem1314 aleem1314 requested a review from a team January 9, 2023 14:57
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanchristo ryanchristo added the backport/v5.0.x backport to release/v5.0.x branch label Jan 11, 2023
@ryanchristo ryanchristo merged commit fdd4424 into main Jan 11, 2023
@ryanchristo ryanchristo deleted the aleem/go-releaser-docker branch January 11, 2023 21:21
mergify bot pushed a commit that referenced this pull request Jan 11, 2023
Co-authored-by: ryanchristo <12519942+ryanchristo@users.noreply.github.com>
(cherry picked from commit fdd4424)

# Conflicts:
#	.github/workflows/build-nightly.yml
#	.github/workflows/release.yml
ryanchristo added a commit that referenced this pull request Jan 11, 2023
…1733) (#1744)

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: ryanchristo <12519942+ryanchristo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.0.x backport to release/v5.0.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go releaser failing with latest update to go 1.19
2 participants