Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): migrate errors to types module #1637

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Nov 23, 2022

Description

We created an errors module with a single file listing grpc errors. I think reusable errors was the right idea but this should be included in the types module. We may want to have a separate module in the future but given the size of this module and the extra steps it adds to the release process, I think it would be better to have the errors added to the existing types module.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review November 23, 2022 21:37
@ryanchristo ryanchristo requested a review from a team November 23, 2022 21:37
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #1637 (0cadff0) into main (6e6cfdb) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 0cadff0 differs from pull request most recent head 7eea464. Consider uploading reports for the commit 7eea464 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
- Coverage   77.76%   77.62%   -0.14%     
==========================================
  Files         266      266              
  Lines       19579    19484      -95     
==========================================
- Hits        15225    15125     -100     
- Misses       3482     3490       +8     
+ Partials      872      869       -3     
Impacted Files Coverage Δ
x/data/server/query_anchor_by_hash.go 86.95% <ø> (ø)
x/data/server/query_anchor_by_iri.go 86.95% <ø> (ø)
x/data/server/query_attestations_by_attestor.go 66.66% <ø> (ø)
x/data/server/query_attestations_by_hash.go 73.33% <ø> (ø)
x/data/server/query_attestations_by_iri.go 73.33% <ø> (ø)
x/data/server/query_convert_hash_to_iri.go 100.00% <ø> (ø)
x/data/server/query_convert_iri_to_hash.go 100.00% <ø> (ø)
x/data/server/query_resolver.go 100.00% <ø> (ø)
x/data/server/query_resolvers_by_hash.go 68.75% <ø> (ø)
x/data/server/query_resolvers_by_iri.go 68.75% <ø> (ø)
... and 40 more

@ryanchristo ryanchristo merged commit e1d8098 into main Nov 24, 2022
@ryanchristo ryanchristo deleted the ryan/migrate-errors-to-types branch November 24, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants