fix(x/intertx): fix ICA integration #1606
Conversation
| @@ -20,10 +20,6 @@ func (m MsgRegisterAccount) ValidateBasic() error { | |||
| return sdkerrors.ErrInvalidAddress.Wrapf("owner: %s", err.Error()) | |||
| } | |||
|
|
|||
| if m.Version == "" { | |||
There was a problem hiding this comment.
Looks like this field is optional ref.
| } | ||
|
|
||
| // UnpackInterfaces implements codectypes.UnpackInterfacesMessage | ||
| func (msg MsgSubmitTx) UnpackInterfaces(unpacker codectypes.AnyUnpacker) error { |
There was a problem hiding this comment.
Without this method, submit-tx returning error cannot unpack Any into type .....
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1606 +/- ##
==========================================
- Coverage 77.53% 77.48% -0.05%
==========================================
Files 264 264
Lines 19288 19298 +10
==========================================
Hits 14954 14954
- Misses 3469 3479 +10
Partials 865 865
|
|
@ryanchristo sample repo to test ICA between Regen and Akash network. |
There was a problem hiding this comment.
tACK using https://github.com/aleem1314/ica-testing 🚀
Just a couple small nits. Great work and thanks for digging into this!
| package v1 | ||
|
|
||
| import sdk "github.com/cosmos/cosmos-sdk/types" | ||
|
|
||
| func init() { | ||
| cfg := sdk.GetConfig() | ||
| cfg.SetBech32PrefixForAccount("regen", "regenpub") | ||
| } |
There was a problem hiding this comment.
I think we can remove this file. We have a config.go file in the root of x/intertx that should apply.
There was a problem hiding this comment.
Removing this file causing V1 package tests fails with error expected cosmos got regen.
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
ryanchristo
changed the title
Description
Found few issues, while testing ICA.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change