Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/ecocredit): remove fee param when amount is zero #1604

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Nov 10, 2022

Description

Closes: #1597


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1604 (8e049a4) into main (1b52730) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8e049a4 differs from pull request most recent head 6ebf6ca. Consider uploading reports for the commit 6ebf6ca to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1604   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         264      264           
  Lines       19288    19288           
=======================================
  Hits        14954    14954           
  Misses       3469     3469           
  Partials      865      865           
Impacted Files Coverage Δ
x/ecocredit/base/keeper/msg_update_class_fee.go 78.57% <100.00%> (ø)
x/ecocredit/basket/keeper/msg_update_basket_fee.go 80.00% <100.00%> (ø)

@aleem1314 aleem1314 marked this pull request as ready for review November 10, 2022 15:48
@aleem1314 aleem1314 requested a review from a team November 10, 2022 15:48
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanchristo ryanchristo changed the title fix(ecocredit): remove fee param when amount is zero fix(x/ecocredit): remove fee param when amount is zero Nov 10, 2022
@ryanchristo ryanchristo merged commit 5e20a2e into main Nov 10, 2022
@ryanchristo ryanchristo deleted the aleem/1597-fee-params branch November 10, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecocredit: unable to create credit class after updating class-fee to 0uregen
3 participants