Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove tests nightly and update sims nightly #1601

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Nov 10, 2022

Description

This pull request removes tests nightly (and liveness test) and updates sims nightly:

  • Tests Nightly only included the liveness test and the liveness test was broken and seemed unnecessary given this test is not specific to the application but rather to a working version of cosmos sdk (and the test is performed on the sdk)
  • Sims Nightly was never completing and always timing out so I lowered the block numbers, which I think is ok given we are also testing with multiple seeds (as opposed to a single seed in the quick pull request workflow)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo force-pushed the ryan/fix-nighly-workflows branch from d78a1c8 to 454c534 Compare January 11, 2023 21:34
@ryanchristo ryanchristo changed the title ci: fix nightly tests and sims ci: remove tests nightly and update sims nighlly Jan 11, 2023
@ryanchristo ryanchristo marked this pull request as ready for review January 11, 2023 21:37
@ryanchristo ryanchristo requested a review from a team January 11, 2023 21:37
@ryanchristo ryanchristo changed the title ci: remove tests nightly and update sims nighlly ci: remove tests nightly and update sims nightly Jan 11, 2023
@ryanchristo ryanchristo merged commit eab12b8 into main Jan 12, 2023
@ryanchristo ryanchristo deleted the ryan/fix-nighly-workflows branch January 12, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants