-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use sdk modules #1357
Merged
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
197afa5
refactor: remove custom module & manager from app
09d0a7c
wip
68f938b
more wip
4f6035d
wip: perhaps this will work...
3ede59a
fix: fill response with baseapp msg routing
0b98dd3
chore: add a panic for unexpected msg response results
7fa0c23
wip: query support
b77f6a4
fix: route queries through baseapp
a489275
chore: cleanup todos and deleted code
3d991b0
fix: use a mock module and force validator updates
680eaa4
docs: remove dead doc
4636fca
refactor: expose weighted operations and use in module
6def4a5
Merge branch 'main' into ty/933-app_module_refactor
15d92e3
refactor: move weighted operations to module
e9b0735
refactor: move simulations away from using old configurator keys
bf4df8c
refactor: simplify msg response check
8696311
refactor: import alias
ace2f43
refactor: remove store key from serverImpl struct
05ceafb
Merge branch 'main' into ty/933-app_module_refactor
20bc237
fix: data test setup
c66423b
refactor: simplify package, add events from response to context
13ea4a0
fix: sdk package errors, remove unused functions
b126ba5
fix: remove cast to custom context
d044a8e
refactor: remove last of custom context
59b6633
fix: remove calls to custom context
cdbb0cd
fix: setup fixture properly
e83c725
docs: add changelog
ed63a0d
Merge branch 'main' into ty/933-app_module_refactor
35a6b5b
refactor: remove unused codec function
8e4a094
chore: consolidate require line
2c90050
chore: apply suggestions from code review
technicallyty d5d3497
Merge branch 'ty/933-app_module_refactor' of https://github.com/regen…
11a061b
Merge branch 'main' into ty/933-app_module_refactor
90d3602
docs: update weighted ops godoc
2306d18
refactor: move weighted ops into module, remove method from server
6ab8b61
Merge branch 'main' into ty/933-app_module_refactor
83a33b5
chore: changelog
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: expose weighted operations and use in module
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -254,8 +254,8 @@ func (Module) RegisterStoreDecoder(_ sdk.StoreDecoderRegistry) {} | |
// WeightedOperations returns all the ecocredit module operations with their respective weights. | ||
// NOTE: This is no longer needed for the modules which uses ADR-33, ecocredit module `WeightedOperations` | ||
// registered in the `x/ecocredit/server` package. | ||
func (Module) WeightedOperations(simState module.SimulationState) []simtypes.WeightedOperation { | ||
return nil | ||
func (a Module) WeightedOperations(simState module.SimulationState) []simtypes.WeightedOperation { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you also update godoc? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 90d3602 👍🏻 |
||
return a.Keeper.WeightedOperations(simState) | ||
} | ||
|
||
// BeginBlock checks if there are any expired sell or buy orders and removes them from state. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can directly call
simulation.WeightedOperations
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2306d18 👍🏻