Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orm): update regen orm to sdk v0.46 #1257

Closed
wants to merge 2 commits into from
Closed

Conversation

aleem1314
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo
Copy link
Member

Not sure if the orm module is being added back in for testing as part of the draft but we should be importing the orm module from the sdk as we are no longer maintaining a separate version of the orm in regen ledger. #1136

@aleem1314
Copy link
Contributor Author

Not sure if the orm module is being added back in for testing as part of the draft but we should be importing the orm module from the sdk as we are no longer maintaining a separate version of the orm in regen ledger. #1136

We are still using regen orm in ecocredit v3 -> v4 state migrations.

@ryanchristo
Copy link
Member

ryanchristo commented Jul 14, 2022

We are still using regen orm in ecocredit v3 -> v4 state migrations.

The migrations shouldn't be updated although I see how updating the sdk version would cause issues. If we update the orm in the migrations, then the migrations would no longer serve their purpose.

I'm not entirely clear on why we need to keep the migrations, especially if we need to make changes. I'll take another look at the sdk documentation and maybe we should discuss on our next call but it seems unnecessary to readd and update the deprecated orm module to update migrations that we will no longer be using moving forward.

@clevinson
Copy link
Member

Closing as we decided not to support historic migrations (v3 => v4 state migrations)

@clevinson clevinson closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants