Validate genesis error: credit batch supply is incorrect

[ryanchristo]

Summary of Bug

After exporting mainnet state and running the validate-genesis command, the following error is returned:

supply is incorrect for 11 credit batch, expected 265.00, got 264.95000: invalid coins

After exporting redwood state and running the validate-genesis command, the following error is returned:

supply is incorrect for 7 credit batch, expected 1000.000000, got 998.000000: invalid coins

Version

v4.1.5 / release/v5.0.x / main

Steps to Reproduce

• export regen mainnet state
• run regen validate-genesis

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[ryanchristo]

Updated to include same error occurring with exported redwood state.

[ryanchristo]

Here is the credit batch throwing the error:

• http://165.232.174.176:1317/regen/ecocredit/v1/supply/C02-001-20180101-20181231-001
• http://165.232.174.176:1317/regen/ecocredit/v1/balances-by-batch/C02-001-20180101-20181231-001

Tradable Balances + Escrowed Balances = Tradable Supply
0.1 + 1.90 + 5 + 225.95 + 10 = 242.95

Retired Balances = Retired Supply
0.05 + 2 + 1 + 1 + 2 + 16 = 22.05

Tradable Supply + Retired Supply = Total Supply
242.95 + 22.05 = 265

From what I can tell with this information, it looks like there is not an issue with the supply itself but rather an issue with the math in the invariant check. I used a different export of mainnet than what the devnet used, so will double check...

[ryanchristo]

Using a more recent mainnet export (also what was used when testing and when I encountered the error):

{
  "tradable_amount": "232.95",
  "retired_amount": "32.05",
  "cancelled_amount": "0"
}

Tradable Balances + Escrowed Balances = Tradable Supply
0.1 + 9.99975 + 1.90 + 5 + 205.90 + 10 + 0.00025 = 232.9 - !!! does not match tradable supply

Retired Balances = Retired Supply
0.05 + 2 + 1 + 10 + 1 + 2 + 16 = 32.05

Tradable Supply + Retired Supply = Total Supply
232.9 + 32.05 = 264.95 - !!! does not match total supply

[ryanchristo]

Worth noting that I have not checked with existing mainnet because balances by batch is a new query so no easy way to get the balances on v4.0. I can confirm that I received the same error with the same export before upgrading though.

• http://mainnet.regen.network:1317/regen/ecocredit/v1/supply/C02-001-20180101-20181231-001
• http://mainnet.regen.network:1317/regen/ecocredit/v1/balances-by-batch/C02-001-20180101-20181231-001

[ryanchristo]

With the msg send fix and migrations in place, I think it's safe to close this issue.