Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transfer ibc proto #40

Merged
merged 1 commit into from
Sep 12, 2022
Merged

feat: add transfer ibc proto #40

merged 1 commit into from
Sep 12, 2022

Conversation

flagrede
Copy link
Contributor

@flagrede flagrede commented Sep 6, 2022 •
edited
Loading

Add proto files and regenerate ts types to use DenomTrace and DenomTraces methods from ibc/applications/transfer package.

@flagrede flagrede marked this pull request as ready for review September 6, 2022 11:30
@flagrede flagrede mentioned this pull request Sep 6, 2022
Merged
11 tasks
haveanicedavid
haveanicedavid approved these changes Sep 6, 2022
View reviewed changes
Copy link

@haveanicedavid haveanicedavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhagel mhagel requested a review from amaury1093 September 12, 2022 16:10
amaury1093
amaury1093 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no manual code, everything is either proto or generated, right? If so, LGTM

@mhagel mhagel merged commit 61c6cd2 into main Sep 12, 2022
@mhagel mhagel deleted the feat-add-transfer-proto branch September 12, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@haveanicedavid haveanicedavid haveanicedavid approved these changes

@mhagel mhagel mhagel approved these changes

@victordelval victordelval Awaiting requested review from victordelval

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flagrede @amaury1093 @haveanicedavid @mhagel